add email queue to handle email sending failures #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahendraHegde
commented
Jan 18, 2025
|
|
||
| export const sendEmail = (payload: EmailPayloadType) => { | ||
| // attempt to send email, push to the queue if it fails | ||
| triggerEmail(payload).catch((err) => { |
There was a problem hiding this comment.
we dont await, so users dont have to wait for long running email api calls.
mahendraHegde
force-pushed
the
email-queue
branch
from
4cfbac9 to
1c22c8a
Compare
mahendraHegde
force-pushed
the
email-queue
branch
from
1c22c8a to
4a92abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triggerEmailcall insidesendEmailanymore, so that any user facing actions can finish without waiting for email send to complete, this is actually a tradeoff, because if email sending fails(1st attempt + 5 retries using queues) user never will be warned, but the case is very unlikely and the benefit supersedes the tradeoff.